Offer fixes suggested by clang-tidy #43
Open
+13
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly from
misc-include-cleaner
:https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html
But also
readability-string-compare
:https://clang.llvm.org/extra/clang-tidy/checks/readability/string-compare.html
And
readability-inconsistent-declaration-parameter-name
:https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html
c.f.
rep-cpp/src/agent.cpp
Line 86 in ca2ae84